NDEV-830. Upgraded Wormhole portal for Neon transfer #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev1n-peters
reviewed
Feb 9, 2023
kev1n-peters
reviewed
Feb 9, 2023
oable
force-pushed
the
main
branch
3 times, most recently
from
67ffbfa to
b5acf3e
Compare
kev1n-peters
approved these changes
Feb 28, 2023
kev1n-peters
suggested changes
Feb 28, 2023
src/store/selectors.ts
Outdated
| ) { | ||
| return "Invalid relayer fee."; | ||
| } | ||
| if ( | ||
| state.transfer.useRelayer && | ||
| (state.transfer.targetChain === CHAIN_ID_ACALA || | ||
| state.transfer.targetChain === CHAIN_ID_KARURA) && | ||
| state.transfer.targetChain === CHAIN_ID_KARURA || | ||
| state.transfer.targetChain === CHAIN_ID_NEON) && | ||
| !state.transfer.acalaRelayerInfo.data?.shouldRelay |
There was a problem hiding this comment.
Need to handle state.transfer.neonRelayerInfo.data?.shouldRelay
There was a problem hiding this comment.
Some think like this?
if ( state.transfer.useRelayer && (state.transfer.targetChain === CHAIN_ID_ACALA || state.transfer.targetChain === CHAIN_ID_KARURA || state.transfer.targetChain === CHAIN_ID_NEON) && (!state.transfer.acalaRelayerInfo.data?.shouldRelay || !state.transfer.neonRelayerInfo.data?.shouldRelay) ) {
There was a problem hiding this comment.
Can we change it to:
if (
(state.transfer.useRelayer &&
(state.transfer.targetChain === CHAIN_ID_ACALA ||
state.transfer.targetChain === CHAIN_ID_KARURA) &&
!state.transfer.acalaRelayerInfo.data?.shouldRelay) ||
(state.transfer.targetChain === CHAIN_ID_NEON &&
!state.transfer.neonRelayerInfo.data?.shouldRelay)
) {
return "Token is ineligible for relay.";
}
4ec4385 to
ed0ad14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.